Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enhance ERC registry update with efficient merge and deduplication #1136

Merged
merged 4 commits into from
Jan 7, 2025
Merged

feat: Enhance ERC registry update with efficient merge and deduplication #1136

merged 4 commits into from
Jan 7, 2025

Conversation

quiet-node
Copy link
Member

@quiet-node quiet-node commented Dec 24, 2024 •
edited
Loading

Description:
This PR introduces a streamlined mechanism to correctly insert new, previously unrecognized ERC contract IDs into a sorted registry. The updated implementation uses Lodash to simplify the process, ensuring contracts are seamlessly merged, de-duplicated, and ordered correctly by their contractId.

Fixes #1130

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the enhancement New feature or request label Dec 24, 2024
@quiet-node quiet-node added this to the 0.12.0 milestone Dec 24, 2024
@quiet-node quiet-node self-assigned this Dec 24, 2024
@quiet-node quiet-node requested review from a team as code owners December 24, 2024 23:59
@quiet-node quiet-node linked an issue Dec 24, 2024 that may be closed by this pull request
[ERC Registry] Phase 3: Implement a sorting mechanism to sort the ERC records to allow back filling #1130
Closed
@quiet-node quiet-node changed the title feat: Enhance registry update with efficient merge and deduplication feat: Enhance ERC registry update with efficient merge and deduplication Dec 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2024 •
edited
Loading

Test Results

 16 files  ±0   83 suites  ±0   12m 13s ⏱️ +11s
289 tests  - 5  282 ✅  - 6  6 💤 ±0  1 ❌ +1 
303 runs  ±0  295 ✅  - 1  7 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 595037f. ± Comparison against base commit 878566d.

This pull request removes 6 and adds 1 tests. Note that renamed tests count towards both. 
Should NOT allow a non-operator to transfer tokens to another account ‑ @OZERC1155Token Test Suite Should NOT allow a non-operator to transfer tokens to another account
Should NOT burn insufficient amount of token ‑ @OZERC1155Token Test Suite Should NOT burn insufficient amount of token
Should allow an operator to transfer a token to another account ‑ @OZERC1155Token Test Suite Should allow an operator to transfer a token to another account
Should allow an operator to transfer tokens in batch to another account ‑ @OZERC1155Token Test Suite Should allow an operator to transfer tokens in batch to another account
Should burn token in batch ‑ @OZERC1155Token Test Suite Should burn token in batch
Should burn token ‑ @OZERC1155Token Test Suite Should burn token

"before each" hook for "Should burn token" ‑ @OZERC1155Token Test Suite "before each" hook for "Should burn token"

♻️ This comment has been updated with latest results.

@quiet-node quiet-node force-pushed the 1130-erc-registry-phase-3-implement-a-sorting-mechanism-to-sort-the-erc-records-to-allow-back-filling branch from f446964 to 98ebe35 Compare December 25, 2024 04:22
natanasow
natanasow previously approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, one suggestion.

tools/erc-repository-indexer/erc-contract-indexer/src/utils/helper.ts Outdated Show resolved Hide resolved
konstantinabl
konstantinabl previously approved these changes Jan 7, 2025
View reviewed changes
@quiet-node quiet-node dismissed stale reviews from konstantinabl and natanasow via 726fc27 January 7, 2025 17:04
@quiet-node quiet-node force-pushed the 1130-erc-registry-phase-3-implement-a-sorting-mechanism-to-sort-the-erc-records-to-allow-back-filling branch from 98ebe35 to 726fc27 Compare January 7, 2025 17:04
@quiet-node quiet-node merged commit 6222087 into main Jan 7, 2025
34 of 36 checks passed
@quiet-node quiet-node deleted the 1130-erc-registry-phase-3-implement-a-sorting-mechanism-to-sort-the-erc-records-to-allow-back-filling branch January 7, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natanasow natanasow natanasow approved these changes

@konstantinabl konstantinabl konstantinabl left review comments

@david-bakin-sl david-bakin-sl Awaiting requested review from david-bakin-sl david-bakin-sl is a code owner automatically assigned from hashgraph/hedera-smart-contracts

Assignees

@quiet-node quiet-node

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

[ERC Registry] Phase 3: Implement a sorting mechanism to sort the ERC records to allow back filling
3 participants
@quiet-node @natanasow @konstantinabl